-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie policy banner hardcodes 2U/edX in a number of places #423
Comments
@arbrandes Here's one for FWG's backlog. |
hardcoded instances (e.g. edx stage, edx prod) are also worth mentioning |
@kdmccormick, the banner part of this issue had been brought up before during the Olive release cycle. It was "solved" (admittedly not ideally) via a configuration option ( Which is to say, the acceptance criteria here can remain as stated, as far as I'm concerned. @dyudyunov, since you seem to be working on this anyway, would you like to be assigned the issue? |
Yeah, I would like to help here I was thinking about several layers for configuration of the text and behavior of the component:
I would also like to know if there is an issue or ticket for adding the banner component in the Header component to reuse it across all the MFE pages. Can you also provide a fork repo URL @kdmccormick mentioned in the description:
|
I don't think we have a specific issue for that, yet. |
Are there any updates for this? I think creating an openedx fork for the component is enough for the work to start. It would be great to create issues/tasks for the following: Update the competent configuration logic:
Include the component to the MFE Header to make it globally available:
Maybe I should create a discussion post first? |
Reproduction
Try to log in via the Authn MFE in Olive. The top of the page shows an edX cookie banner (try private/incognito if you don't see it):
Issues
From https://github.com/openedx/frontend-component-cookie-policy-banner:
Additionally, its package.json requres
@edx/brand-edx.org
.Finally, these strings definitely aren't internationalized the way MFE strings usually are: https://github.com/openedx/frontend-component-cookie-policy-banner/blob/master/src/constants.js
Acceptance Criteria
edx
.@edx/brand-openedx
package is installed instead of@edx/brand-edx.org
.To achieve (1) without disrupting edx.org, 2U would create its own frontend-component-cookie-policy-banner-edx repository to override this one, much like frontend-component-header-edx overrides frontend-component-header.
The text was updated successfully, but these errors were encountered: