Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle broken URL in iframe #71

Open
deborahgu opened this issue Jun 12, 2024 · 0 comments
Open

Handle broken URL in iframe #71

deborahgu opened this issue Jun 12, 2024 · 0 comments

Comments

@deborahgu
Copy link
Member

Currently if we pass a non-existent or broken URL to an iFrame plugin, it will simply render a loading spinner with no indication that a failure has occurred.

loading spinner in an iframe slot

There is a network request being made to the URL with a failing response that can be seen in the Network tab of DevTools (CMD + OPTION + I)

Consider finding a way to ping the URL before passing it to the iframe — perhaps using something like an XMLHttpRequest

Acceptance Criteria

  • There should be a visual indication that the URL has failed
    • The Loading spinner should be hidden at the very least
    • Might be valuable to loop in UX expertise on what the best option is for Alert text
  • The error should be logged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant