-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy/paste: implement "Copy" menu in frontend #10
Comments
@ali-hugo It turns out that these existing Studio "toasts" don't support a "Complete" message; they just disappear when they're done. So it can say "Copying component" with the gear spinning, but there's no easy way to display "Copied!" without the gear spinning, and if I do so it would be different than all the other similar notifications in Studio. I can still find a way to implement it but it will take longer. How important is the "Copied!" success message? I can always create a separate task to implement it later if we have extra time. |
@bradenmacdonald If there's time left over, I think it might be worthwhile implementing the success message. Here's why: When a component is duplicated, something happens on the screen (i.e. a second version of the component appears), but when a component is copied, nothing changes on the screen, so the user doesn't get any confirmation that the copy was successful. That said, it would be interesting to see how test users cope without the success message, so we could always leave it off for now, and add it if usability testing proves it to be necessary. What do you think? |
@ali-hugo Sure, I think we'll have time so I should be able to take that on. |
For users with the feature flag #11 active, display the new "Copy" action in the Studio menu #50. Clicking it should use the new backend copy API from #51 to copy the component onto the clipboard. Display the status as a toast per the wireframes:
The text was updated successfully, but these errors were encountered: