Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Align "Back to profile" button title #315

Closed
sergeymomot opened this issue Mar 6, 2024 · 2 comments · Fixed by #345
Closed

[iOS] Align "Back to profile" button title #315

sergeymomot opened this issue Mar 6, 2024 · 2 comments · Fixed by #345
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@sergeymomot
Copy link

sergeymomot commented Mar 6, 2024

Open Profile -> Edit -> tap Delete account -> observe "Back to profile" button: button name is moved down.
This issue applies to iPhone and iPad.
064542c8-505f-4809-9751-1c2cd7b2004a

c40c4aed-f5f2-4481-948a-bcc0494aee50

Need to align the button title

As a possible solution - we can simply remove this button, since at the top left there is a "Back" button that performs the same action

@sergeymomot sergeymomot added the bug Report of or fix for something that isn't working as intended label Mar 6, 2024
@rnr
Copy link
Contributor

rnr commented Mar 11, 2024

Hello @sdaitzman
Are you ok if we get rid this button or it's needed for some design purposes?
Thank you

@rnr rnr self-assigned this Mar 11, 2024
@sdaitzman
Copy link

Hi @rnr, thank you for tagging me to check about this. I think it would be preferable to keep the Back to Profile button if possible.

From a design standpoint, screens that allow a destructive action should include a quick and clear default action to opt out of that destructive action. It's not a frequent situation, but e.g. if a user has entered their password but realized that they do not want to delete their account, it should be clear that the default action is to go back without deleting their account.

On this screen, I also think the Delete Account button should eventually use the red error/danger color with an outlined (secondary) button style, and the Back to Profile button should use the primary button style. This would emphasize which action is destructive. Those changes may fall under some future design enhancements within account settings/profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants