Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add single sign on feature using SAML #447

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

RawanMatar89
Copy link

@RawanMatar89 RawanMatar89 commented Jun 2, 2024

Describtion:

added new button in sign in view named "Sign in with SSO" to be use for opening single sign on web view

Screenshots:

Before After
Simulator Screenshot - iPhone 15 Pro - 2024-06-02 at 09 50 09 Simulator Screenshot - iPhone 15 Pro - 2024-06-02 at 11 10 17
e.g. when tap on "Sign in with SSO" Simulator Screenshot - iPhone 15 Pro - 2024-06-02 at 11 10 12

TODO:

  • Rebase and remove the RTL commit
  • Fix unit tests
  • Get a full review

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 2, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @RawanMatar89! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi
Copy link
Member

@RawanMatar89 please rebase over openedx:develop, resolve conflicts and fix the failing tests like:

[ProfileTests] Write Auxiliary File ProfileTests_vers.c
Error: type 'AuthInteractorProtocolMock' does not conform to protocol 'AuthInteractorProtocol'
open class AuthInteractorProtocolMock: AuthInteractorProtocol, Mock {
           ^
Error: type 'BaseRouterMock' does not conform to protocol 'BaseRouter'
open class BaseRouterMock: BaseRouter, Mock {
           ^
Error: type 'ProfileRouterMock' does not conform to protocol 'BaseRouter'
open class ProfileRouterMock: ProfileRouter, Mock {
           ^
[ProfileTests] Compiling EditProfileViewModelTests.swift
Testing failed:
	Type 'AuthInteractorProtocolMock' does not conform to protocol 'AuthInteractorProtocol'
	Type 'BaseRouterMock' does not conform to protocol 'BaseRouter'
	Type 'ProfileRouterMock' does not conform to protocol 'BaseRouter'
	Command SwiftCompile failed with a nonzero exit code
	Testing cancelled because the build failed.

** TEST FAILED **


The following build commands failed:
	SwiftEmitModule normal arm64 Emitting\ module\ for\ ProfileTests (in target 'ProfileTests' from project 'Profile')
	SwiftCompile normal arm64 Compiling\ ProfileMock.generated.swift,\ DeleteAccountViewModelTests.swift /Users/runner/work/openedx-app-ios/openedx-app-ios/Profile/ProfileTests/ProfileMock.generated.swift /Users/runner/work/openedx-app-ios/openedx-app-ios/Profile/ProfileTests/Presentation/DeleteAccount/DeleteAccountViewModelTests.swift (in target 'ProfileTests' from project 'Profile')
(2 failures)

@OmarIthawi
Copy link
Member

@volodymyr-chekyrta we have a big feature that we'd like to merge here: SAML SSO.

I've assigned as a Reviewer, I understand you have other projects at hand so feel free to assign someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

None yet

3 participants