Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

["BUG"] Included Unneeded Folders #74

Closed
felipemontoya opened this issue May 16, 2024 · 0 comments · Fixed by #76
Closed

["BUG"] Included Unneeded Folders #74

felipemontoya opened this issue May 16, 2024 · 0 comments · Fixed by #76
Assignees
Labels
bug Report of or fix for something that isn't working as intended help wanted Ready to be picked up by anyone in the community

Comments

@felipemontoya
Copy link
Member

Describe the bug
From the feedback received from the wordpress review team.

This plugin includes folders and files that looks like are not required for the running of your plugin. Some examples are:

development tools
unneeded vendor folders for production (bower, node, grunt, etc)
demos
unit tests

If you're trying to include the human-readable version of your own code (in order to comply with our guidelines) that's fine, remember that we also permit you to put links to them in your readme.

You should also keep and/or link configuration files, as for example, the composer.json file in order to allow others to review, study, and yes, fork this code.

https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/#4-code-must-be-mostly-human-readable

But you can, and should, safely remove those other unneeded folders from your plugins.

From your plugin:

08_18-10-54_openedx-commerce/vendor/nikic/php-parser
08_18-10-54_openedx-commerce/vendor/phar-io/manifest/.github
08_18-10-54_openedx-commerce/vendor/phpunit
08_18-10-54_openedx-commerce/vendor/myclabs/deep-copy/.github
08_18-10-54_openedx-commerce/vendor/phpunit/phpunit
08_18-10-54_openedx-commerce/vendor/phpunit/phpunit/src/TextUI/XmlConfiguration/PHPUnit

@felipemontoya felipemontoya added bug Report of or fix for something that isn't working as intended help wanted Ready to be picked up by anyone in the community labels May 16, 2024
@MaferMazu MaferMazu self-assigned this May 17, 2024
@MaferMazu MaferMazu linked a pull request Jun 6, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended help wanted Ready to be picked up by anyone in the community
Projects
None yet
2 participants