Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "report" and "report outline" icons [PAR-701] [PAR-702] #1139

Merged
merged 1 commit into from Mar 11, 2022

Conversation

xitij2000
Copy link
Contributor

@xitij2000 xitij2000 commented Mar 10, 2022

Adds icons for report and an outline variant of the report icon.

Screenshot_20220310_220801

Adds icons for report and an outline variant of the report icon.
@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Mar 10, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @xitij2000! I've created OSPR-6515 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@netlify
Copy link

netlify bot commented Mar 10, 2022

✔️ Deploy Preview for paragon-edx ready!

🔨 Explore the source changes: 6ccc471

🔍 Inspect the deploy log: https://app.netlify.com/sites/paragon-edx/deploys/622a257a49dd080008f5568a

😎 Browse the preview: https://deploy-preview-1139--paragon-edx.netlify.app

@netlify
Copy link

netlify bot commented Mar 10, 2022

✔️ Deploy Preview for paragon-openedx ready!

🔨 Explore the source changes: 6ccc471

🔍 Inspect the deploy log: https://app.netlify.com/sites/paragon-openedx/deploys/622a257ad838f700088efc38

😎 Browse the preview: https://deploy-preview-1139--paragon-openedx.netlify.app

@xitij2000 xitij2000 changed the title feat: add "report" and "report outline" icons feat: add "report" and "report outline" icons [PAR-701] [PAR-702] Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1139 (6ccc471) into master (05c52b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1139   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         190      190           
  Lines        2989     2989           
  Branches      657      657           
=======================================
  Hits         2708     2708           
  Misses        268      268           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c52b4...6ccc471. Read the comment docs.

Copy link

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xitij2000 👍 LGTM

@adamstankiewicz adamstankiewicz merged commit 564056a into openedx:master Mar 11, 2022
@openedx-webhooks
Copy link

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 19.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants