New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: Bubble component #1205
[BD-46] feat: Bubble component #1205
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the pull request, @monteri! I've created BLENDED-1178 to keep track of it in Jira. More details are on the BD-46 project page. When this pull request is ready, tag your edX technical lead. |
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
==========================================
+ Coverage 90.74% 90.87% +0.13%
==========================================
Files 193 194 +1
Lines 3070 3103 +33
Branches 691 698 +7
==========================================
+ Hits 2786 2820 +34
+ Misses 271 270 -1
Partials 13 13
Continue to review full report at Codecov.
|
src/Bubble/README.md
Outdated
() => { | ||
return ( | ||
<> | ||
<div style={{ display: 'flex', alignItems: 'center', width: '200px', justifyContent: 'space-between', marginBottom: '10px' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] This might be a bit cleaner/shorter for the code snippet:
<Stack direction="horizontal" gap={4} className="mb-2">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, Stack
is added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😄
@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 19.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
New Bubble component:
variant
,disabled
,className
Deploy Preview
https://deploy-preview-1205--paragon-openedx.netlify.app/