Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: Bubble component #1205

Merged

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Apr 1, 2022

Description

New Bubble component:

  • implement props: variant, disabled, className
  • tests
  • examples

Deploy Preview

https://deploy-preview-1205--paragon-openedx.netlify.app/

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program needs triage labels Apr 1, 2022
@netlify
Copy link

netlify bot commented Apr 1, 2022

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 05c0f58
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/625052b40d78750008a295ad
😎 Deploy Preview https://deploy-preview-1205--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openedx-webhooks
Copy link

Thanks for the pull request, @monteri! I've created BLENDED-1178 to keep track of it in Jira. More details are on the BD-46 project page.

When this pull request is ready, tag your edX technical lead.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1205 (05c0f58) into master (9e4ea4b) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
+ Coverage   90.74%   90.87%   +0.13%     
==========================================
  Files         193      194       +1     
  Lines        3070     3103      +33     
  Branches      691      698       +7     
==========================================
+ Hits         2786     2820      +34     
+ Misses        271      270       -1     
  Partials       13       13              
Impacted Files Coverage Δ
src/Bubble/index.jsx 100.00% <100.00%> (ø)
src/Stepper/StepperHeaderStep.jsx 100.00% <100.00%> (ø)
src/Dropdown/index.jsx 97.22% <0.00%> (-2.78%) ⬇️
src/DataTable/index.jsx 94.82% <0.00%> (ø)
src/Toast/index.jsx 66.66% <0.00%> (+5.12%) ⬆️
src/utils/propTypesUtils.js 90.90% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4ea4b...05c0f58. Read the comment docs.

src/Bubble/README.md Show resolved Hide resolved
() => {
return (
<>
<div style={{ display: 'flex', alignItems: 'center', width: '200px', justifyContent: 'space-between', marginBottom: '10px' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] This might be a bit cleaner/shorter for the code snippet:

<Stack direction="horizontal" gap={4} className="mb-2">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, Stack is added

src/Bubble/README.md Show resolved Hide resolved
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@adamstankiewicz adamstankiewicz merged commit 01b1a9f into openedx:master Apr 15, 2022
@openedx-webhooks
Copy link

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 19.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants