Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use React.cloneElement vs. React.createElement to prevent extra re-rendering and remove "key" warning. #1245

Merged
merged 2 commits into from Apr 21, 2022

Conversation

adamstankiewicz
Copy link
Member

Description

TBD

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Apr 20, 2022

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 7972876
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/62604bbffb737e00087f061f
😎 Deploy Preview https://deploy-preview-1245--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1245 (7972876) into master (f3b49a9) will decrease coverage by 0.03%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   90.94%   90.91%   -0.04%     
==========================================
  Files         195      195              
  Lines        3149     3149              
  Branches      702      702              
==========================================
- Hits         2864     2863       -1     
- Misses        272      273       +1     
  Partials       13       13              
Impacted Files Coverage Δ
src/Tabs/index.jsx 93.33% <90.90%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b49a9...7972876. Read the comment docs.

@adamstankiewicz adamstankiewicz changed the title fix: ensure tab children has unique key prop fix: use React.cloneElement vs. React.createElement to prevent extra re-rendering and remove "key" warning. Apr 21, 2022
@adamstankiewicz adamstankiewicz merged commit a5bafa3 into master Apr 21, 2022
@adamstankiewicz adamstankiewicz deleted the astankiewicz/tabs-fixes branch April 21, 2022 01:51
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 19.18.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants