Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] is-mutted props for card #1455

Merged
merged 1 commit into from Jul 29, 2022

Conversation

Inferato
Copy link
Contributor

@Inferato Inferato commented Jul 8, 2022

Description

is-mutted props for Card component were added

Github issue: #1376

Deploy Preview

https://deploy-preview-1455--paragon-openedx.netlify.app/components/card/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @Inferato!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jul 8, 2022
@netlify
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 804d41f
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/62d0fe3c93f32e0008993045
😎 Deploy Preview https://deploy-preview-1455--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1455 (804d41f) into master (ba78533) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         205      205           
  Lines        3438     3438           
  Branches      799      799           
=======================================
  Hits         3139     3139           
  Misses        285      285           
  Partials       14       14           
Impacted Files Coverage Δ
src/Card/index.jsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba78533...804d41f. Read the comment docs.

@viktorrusakov viktorrusakov linked an issue Jul 13, 2022 that may be closed by this pull request
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inferato The Card.Section component already accepts a muted prop to have this styling, e.g.:

<Card>
  <Card.Section muted>
    This is a card section. It can contain anything but usually text, a list, or list of links. Multiple sections have a card divider between them.
  </Card.Section>
</Card>

This issue was largely to provide an example of what a standalone muted Card.Section looks like, not introducing a muted prop on the top-level Card itself; I should have been more explicit in the issue description, my bad!

We do show an example Card.Section with muted already but I think I'd like to see the muted example as the only Card.Section inside of the Card so the resulting effect is a card completely filled with the muted, light gray background.

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Jul 15, 2022

@Inferato The Card.Section component already accepts a muted prop to have this styling, e.g.:

<Card>
  <Card.Section muted>
    This is a card section. It can contain anything but usually text, a list, or list of links. Multiple sections have a card divider between them.
  </Card.Section>
</Card>

This issue was largely to provide an example of what a standalone muted Card.Section looks like, not introducing a muted prop on the top-level Card itself; I should have been more explicit in the issue description, my bad!

We do show an example Card.Section with muted already but I think I'd like to see the muted example as the only Card.Section inside of the Card so the resulting effect is a card completely filled with the muted, light gray background.

Ignore this. After clarifying with UX during the RG sync, we decided to continue to work with a muted prop on the top-level Card component.

@adamstankiewicz adamstankiewicz merged commit 5f1645d into openedx:master Jul 29, 2022
@openedx-webhooks
Copy link

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-semantic-release pushed a commit that referenced this pull request Jul 29, 2022
# [20.6.0](v20.5.0...v20.6.0) (2022-07-29)

### Bug Fixes

* incorrect display of responsive tables in the DataTable component ([#1332](#1332)) ([d112c31](d112c31))
* update dependencies and fix vulnerabilities ([#1431](#1431)) ([c442bb0](c442bb0))

### Features

* add message about file restrictions to default state of `Dropzone` ([#1470](#1470)) ([a4027b8](a4027b8))
* muted prop for card to give light gray background ([#1455](#1455)) ([5f1645d](5f1645d))
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Card full muted example
4 participants