New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] is-mutted props for card #1455
Conversation
Thanks for the pull request, @Inferato! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## master #1455 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 205 205
Lines 3438 3438
Branches 799 799
=======================================
Hits 3139 3139
Misses 285 285
Partials 14 14
Continue to review full report at Codecov.
|
8483d5a
to
804d41f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Inferato The Card.Section
component already accepts a muted
prop to have this styling, e.g.:
<Card>
<Card.Section muted>
This is a card section. It can contain anything but usually text, a list, or list of links. Multiple sections have a card divider between them.
</Card.Section>
</Card>
This issue was largely to provide an example of what a standalone muted Card.Section
looks like, not introducing a muted
prop on the top-level Card
itself; I should have been more explicit in the issue description, my bad!
We do show an example Card.Section
with muted
already but I think I'd like to see the muted
example as the only Card.Section
inside of the Card
so the resulting effect is a card completely filled with the muted, light gray background.
Ignore this. After clarifying with UX during the RG sync, we decided to continue to work with a muted prop on the top-level |
@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
# [20.6.0](v20.5.0...v20.6.0) (2022-07-29) ### Bug Fixes * incorrect display of responsive tables in the DataTable component ([#1332](#1332)) ([d112c31](d112c31)) * update dependencies and fix vulnerabilities ([#1431](#1431)) ([c442bb0](c442bb0)) ### Features * add message about file restrictions to default state of `Dropzone` ([#1470](#1470)) ([a4027b8](a4027b8)) * muted prop for card to give light gray background ([#1455](#1455)) ([5f1645d](5f1645d))
🎉 This PR is included in version 20.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
is-mutted props for Card component were added
Github issue: #1376
Deploy Preview
https://deploy-preview-1455--paragon-openedx.netlify.app/components/card/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist