New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: FormAutosuggest component #1586
[BD-46] feat: FormAutosuggest component #1586
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
da192f4
to
4f0ec62
Compare
Codecov ReportBase: 90.40% // Head: 90.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
+ Coverage 90.40% 90.44% +0.03%
==========================================
Files 208 210 +2
Lines 3534 3684 +150
Branches 824 867 +43
==========================================
+ Hits 3195 3332 +137
- Misses 324 337 +13
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4f0ec62
to
eb44f9a
Compare
66d67b8
to
1324aff
Compare
b211f06
to
6c657f8
Compare
6c657f8
to
0a8b508
Compare
@PKulkoRaccoonGang I believe I'm still seeing some odd behavior with the left/right arrow key navigation. If I press the left arrow key when there are menu options visible, it puts focus on the first menu item instead of moving the cursor in the input field to the left one character. |
cae59e8
to
3160644
Compare
3160644
to
9f5972e
Compare
@adamstankiewicz navigation bug fixed, please see this pull request. |
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
# [20.17.0](v20.16.0...v20.17.0) (2022-10-21) ### Features * FormAutosuggest component ([#1586](#1586)) ([7fbf86d](7fbf86d))
🎉 This PR is included in version 20.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Figma
Deploy Preview
FormAutosuggest component
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist