Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: FormAutosuggest component #1586

Merged

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Aug 26, 2022

Description

Figma

Deploy Preview

FormAutosuggest component

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Aug 26, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f5972e
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/63515c291a75750008433120
😎 Deploy Preview https://deploy-preview-1586--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] feat: FormAutosuggest component [BD-46] DRAFT: FormAutosuggest component Aug 26, 2022
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/FormAutosuggest-component branch from da192f4 to 4f0ec62 Compare August 28, 2022 18:23
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Base: 90.40% // Head: 90.44% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (3160644) compared to base (9942559).
Patch coverage: 90.00% of modified lines in pull request are covered.

❗ Current head 3160644 differs from pull request most recent head 9f5972e. Consider uploading reports for the commit 9f5972e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
+ Coverage   90.40%   90.44%   +0.03%     
==========================================
  Files         208      210       +2     
  Lines        3534     3684     +150     
  Branches      824      867      +43     
==========================================
+ Hits         3195     3332     +137     
- Misses        324      337      +13     
  Partials       15       15              
Impacted Files Coverage Δ
src/hooks/useArrowKeyNavigation.js 18.18% <20.00%> (-0.87%) ⬇️
src/Form/FormAutosuggest.jsx 93.25% <93.25%> (ø)
src/Form/FormAutosuggestOption.jsx 100.00% <100.00%> (ø)
src/Form/index.jsx 100.00% <100.00%> (ø)
src/Modal/ModalLayer.jsx 68.42% <0.00%> (-31.58%) ⬇️
src/Truncate/utils.js 100.00% <0.00%> (ø)
src/Truncate/index.jsx 100.00% <0.00%> (ø)
src/PageBanner/index.jsx 91.66% <0.00%> (ø)
src/Card/CardImageCap.jsx 100.00% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/FormAutosuggest-component branch from 4f0ec62 to eb44f9a Compare August 28, 2022 18:58
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFT: FormAutosuggest component [BD-46] feat: FormAutosuggest component Aug 30, 2022
@adamstankiewicz adamstankiewicz linked an issue Sep 2, 2022 that may be closed by this pull request
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Show resolved Hide resolved
src/Form/FormAutosuggest.jsx Outdated Show resolved Hide resolved
src/Form/form-autosuggest.mdx Show resolved Hide resolved
src/Form/FormAutosuggestOption.jsx Outdated Show resolved Hide resolved
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/FormAutosuggest-component branch 2 times, most recently from 66d67b8 to 1324aff Compare October 7, 2022 01:04
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/FormAutosuggest-component branch from b211f06 to 6c657f8 Compare October 7, 2022 10:54
@adamstankiewicz
Copy link
Member

@PKulkoRaccoonGang I believe I'm still seeing some odd behavior with the left/right arrow key navigation. If I press the left arrow key when there are menu options visible, it puts focus on the first menu item instead of moving the cursor in the input field to the left one character.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/FormAutosuggest-component branch 5 times, most recently from cae59e8 to 3160644 Compare October 20, 2022 13:57
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/FormAutosuggest-component branch from 3160644 to 9f5972e Compare October 20, 2022 14:33
@PKulkoRaccoonGang
Copy link
Contributor Author

@adamstankiewicz navigation bug fixed, please see this pull request.

@adamstankiewicz adamstankiewicz merged commit 7fbf86d into openedx:master Oct 21, 2022
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-semantic-release pushed a commit that referenced this pull request Oct 21, 2022
# [20.17.0](v20.16.0...v20.17.0) (2022-10-21)

### Features

* FormAutosuggest component ([#1586](#1586)) ([7fbf86d](7fbf86d))
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build Form.Autosuggest Component
5 participants