Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] fix: update styles for Chip #1606

Merged
merged 1 commit into from Sep 30, 2022
Merged

[BD-46] fix: update styles for Chip #1606

merged 1 commit into from Sep 30, 2022

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Sep 5, 2022 •
edited

Description

Increase left and right paddings for label.

Deploy Preview

https://deploy-preview-1606--paragon-openedx.netlify.app/components/chip/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 5, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 5, 2022 •
edited

Thanks for the pull request, @monteri!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Sep 5, 2022 •
edited

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c3374b3
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/631610d7151907000886189e
😎 Deploy Preview https://deploy-preview-1606--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@monteri monteri linked an issue Sep 5, 2022 that may be closed by this pull request
Increase padding between Chip label and icons #1599
Closed
@monteri monteri changed the title fix: update styles for Chip [BD-46] fix: update styles for Chip Sep 5, 2022
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Sep 5, 2022
@adamstankiewicz adamstankiewicz merged commit df4583f into openedx:master Sep 30, 2022
@openedx-webhooks
Copy link

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-semantic-release pushed a commit that referenced this pull request Sep 30, 2022
@semantic-release-bot
chore(release): 20.12.1 [skip ci]
9d2cfbf 
## [20.12.1](v20.12.0...v20.12.1) (2022-09-30)

### Bug Fixes

* floating label expand beyond input field ([#1605](#1605)) ([2f89035](2f89035))
* update styles for Chip ([#1606](#1606)) ([df4583f](df4583f))
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
2U Blended Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase padding between Chip label and icons
5 participants
@monteri @openedx-webhooks @edx-semantic-release @adamstankiewicz @vzadorozhnii