New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: Added fallback props to Card component #1682
[BD-46] feat: Added fallback props to Card component #1682
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
cf74c50
to
6382680
Compare
Codecov ReportBase: 90.36% // Head: 90.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1682 +/- ##
==========================================
+ Coverage 90.36% 90.40% +0.04%
==========================================
Files 208 208
Lines 3580 3587 +7
Branches 838 840 +2
==========================================
+ Hits 3235 3243 +8
+ Misses 330 329 -1
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
548dc07
to
e9185bd
Compare
e9185bd
to
4ec127e
Compare
183d444
to
8750277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
@PKulkoRaccoonGang D'oh, I spoke too soon. I just realized the CI is failing on linting. Code changes look good though! That said, are these additional props something we can add tests for, too? |
@adamstankiewicz true, added new tests and fixed linting issues, should be good to go now! |
Thanks @viktorrusakov! |
# [20.14.0](v20.13.0...v20.14.0) (2022-10-19) ### Features * Added fallback image src props to Card component ([#1682](#1682)) ([c0a1f6c](c0a1f6c))
🎉 This PR is included in version 20.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
fallbackSrc
prop to theCard.ImageCap
component, use thisurl
for image if image from the src prop does not load;fallbackLogoSrc
prop to Card.ImageCap component, use thisurl
for logo if image from thelogoSrc
prop does not load;ExamplePropsForm.jsx
.Deploy Preview
Cards component
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist