Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added accentB background for page banner #1688

Merged
merged 1 commit into from Oct 19, 2022
Merged

feat: added accentB background for page banner #1688

merged 1 commit into from Oct 19, 2022

Conversation

mehaknasir
Copy link
Contributor

@mehaknasir mehaknasir commented Oct 14, 2022

Description

Feature Ticket: https://2u-internal.atlassian.net/browse/INF-599
Figma designs supporting required change: https://www.figma.com/file/LVFnO9oRHYiamoicZuXDAC/Discussions?node-id=6884%3A261359

Page banners do not accept background color classes hence we need to add a new variant that can help achieve a design requirement in discussion MFE.

  • accentB color background is added with variant name accentB.
  • documentation is updated to state available variants
  • test cases added to ensure the required color class is added in the background.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 33a6525
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/63504dec3b40ec0009759975
😎 Deploy Preview https://deploy-preview-1688--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 90.36% // Head: 90.36% // No change to project coverage 👍

Coverage data is based on head (e7662fc) compared to base (3dad628).
Patch has no changes to coverable lines.

❗ Current head e7662fc differs from pull request most recent head 33a6525. Consider uploading reports for the commit 33a6525 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1688   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files         208      208           
  Lines        3580     3580           
  Branches      838      838           
=======================================
  Hits         3235     3235           
  Misses        330      330           
  Partials       15       15           
Impacted Files Coverage Δ
src/PageBanner/index.jsx 91.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! LGTM.

@mehaknasir mehaknasir merged commit 0942daa into master Oct 19, 2022
@mehaknasir mehaknasir deleted the inf-599 branch October 19, 2022 19:56
edx-semantic-release pushed a commit that referenced this pull request Oct 19, 2022
# [20.15.0](v20.14.0...v20.15.0) (2022-10-19)

### Features

* added accentB background for page banner ([#1688](#1688)) ([0942daa](0942daa))
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants