New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added accentB background for page banner #1688
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 90.36% // Head: 90.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1688 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 208 208
Lines 3580 3580
Branches 838 838
=======================================
Hits 3235 3235
Misses 330 330
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! LGTM.
# [20.15.0](v20.14.0...v20.15.0) (2022-10-19) ### Features * added accentB background for page banner ([#1688](#1688)) ([0942daa](0942daa))
🎉 This PR is included in version 20.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Feature Ticket: https://2u-internal.atlassian.net/browse/INF-599
Figma designs supporting required change: https://www.figma.com/file/LVFnO9oRHYiamoicZuXDAC/Discussions?node-id=6884%3A261359
Page banners do not accept background color classes hence we need to add a new variant that can help achieve a design requirement in discussion MFE.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist