Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: move hooks to utils in the usage insights #1715

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Oct 25, 2022

Description

Hooks are displayed in the production mode. component?.name always give undefined in production mode and replaced by componentName

Deploy Preview

https://deploy-preview-1715--paragon-openedx.netlify.app/insights

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Oct 25, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @monteri!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e9c57e6
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/635a43444042c900092c7dda
😎 Deploy Preview https://deploy-preview-1715--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 90.51% // Head: 90.51% // No change to project coverage 👍

Coverage data is based on head (e9c57e6) compared to base (9e40306).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1715   +/-   ##
=======================================
  Coverage   90.51%   90.51%           
=======================================
  Files         211      211           
  Lines        3713     3713           
  Branches      872      872           
=======================================
  Hits         3361     3361           
  Misses        337      337           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov viktorrusakov linked an issue Oct 26, 2022 that may be closed by this pull request
@monteri monteri force-pushed the zadorozhnii/usage-insights-hooks-fix branch from e601918 to e9c57e6 Compare October 27, 2022 08:37
@adamstankiewicz adamstankiewicz merged commit d726ad1 into openedx:master Nov 4, 2022
@openedx-webhooks
Copy link

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-semantic-release pushed a commit that referenced this pull request Nov 10, 2022
## [20.18.1](v20.18.0...v20.18.1) (2022-11-10)

### Bug Fixes

* added translations English strings in FormAutosuggest component ([#1711](#1711)) ([782cfb8](782cfb8))
* fixed close button positioning in modal components ([#1733](#1733)) ([9d24187](9d24187))
* fixed onToggle prop ([#1719](#1719)) ([fe21655](fe21655))
* hooks are displayed in production ([#1715](#1715)) ([d726ad1](d726ad1))
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hooks are not displayed on Usage Insights page
6 participants