Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: use fixed position for ProductTour Checkpoints's #2863

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented Nov 27, 2023

Description

Fixes a bug with ProductTour's positioning.

Screen.Recording.2023-11-27.at.11.21.58.mov

Deploy Preview

https://deploy-preview-2863--paragon-openedx.netlify.app/components/producttour/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @viktorrusakov!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 27, 2023
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 15a68fc
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/65645d5c4ab5c200084edf2a
😎 Deploy Preview https://deploy-preview-2863--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (879449f) 92.83% compared to head (15a68fc) 92.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2863   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         235      235           
  Lines        4240     4240           
  Branches     1029     1029           
=======================================
  Hits         3936     3936           
  Misses        300      300           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I also checked the functionality of the ProductTour component in MFE Learning.

@adamstankiewicz adamstankiewicz merged commit f914aeb into master Dec 8, 2023
10 checks passed
@adamstankiewicz adamstankiewicz deleted the rusakov/fix-product-tour-scroll branch December 8, 2023 14:04
@openedx-semantic-release-bot

🎉 This PR is included in version 21.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[alpha] Problem with ProductTour button, after calculations CSS variables
6 participants