fix: update iconAfter prop type definition #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
deleted the
astankiewicz/button-prop-types-iconAfter
branch
|
🎉 This PR is included in version 16.14.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
Buttoncomponent'siconAfterprop type toPropTypes.oneOfTypeinstead ofPropTypes.instanceOfto match theiconBeforeprop. Also, generally it doesn't seemPropTypes.instanceOfactually supports passing an array to it for multiple types per its implementation:https://github.com/facebook/prop-types/blob/4de0644a10a554d0a556daa39f029369bc007ea5/factoryWithTypeCheckers.js#L297-L307
Also, configures Jest to ignore tests in the
dependent-usage-analyzerdirectory (which may include Git checkouts of 30+ projects). Running tests with these projects checked out resulted in Jest attempting to run tests in all projects.