Debugging persistent grade issues

[antoviaque]

Contributor meetup topic imported from https://openedx.atlassian.net/wiki/spaces/COMM/pages/3934289923/2023-11-28+CC+Working+Group+Meeting+Notes

Debugging persistent grade issues

• Presenter: @pdpinch
• Notes: Dave Ormsbee (Axim) offered to connect with Peter Pinch later to check on the issue. Last meeting, neither Peter or Dave were present in the meeting
• Action items: Edward Zarecor will respond in the thread to ask if this is solved

[antoviaque]

• New information in the forum thread
• @pdpinch "would like help reviewing feedback on PR 33963 which fixes a bug found with persistent grades." (from last core sprint retro)

[e0d]

@jansenk from 2U has agreed to review the PR.

[antoviaque]

@e0d @jansenk @itsjeyd @mphilbrick211 It doesn't look like this review is going to happen, no? In that case, is there a core contributor or another maintainer that we could assign here? CC @pdpinch

[itsjeyd]

@antoviaque My understanding from the most recent meeting of the Maintenance WG is that for edx-platform, right now it's fine to go to CCs for review by default.

But ... [this spreadsheet is] the source of Truth moving forward for now and for [edx-]platform go to cc's first ...

As for which CC(s) would be in the best position to take the review based on their area of expertise, I'm not sure.

CC @feanil @mphilbrick211 @pdpinch

[antoviaque]

@itsjeyd Yes, it's also my understanding - though it would also be worth pinging the maintainer listed in the spreadsheet for edx-platform?

For finding the right core contributor for reviewing this PR, maybe @bradenmacdonald could be a good reviewer, or know the right core contributor for this?

[itsjeyd]

@antoviaque Sounds good 🙂

@bradenmacdonald Would you have bandwidth to review openedx/edx-platform#33963, or a recommendation for another CC we could ask?

If not, we'll ping the arch-bom team.

CC @mphilbrick211

[bradenmacdonald]

@itsjeyd I have bandwidth but am not very knowledgeable around grading issues. Would be great if someone with more grading knowledge could review; if nobody is available I'm willing to take a stab at it.

[itsjeyd]

@bradenmacdonald OK, we'll see if we can find another CC in the coming days.

CC @mphilbrick211

[ziafazal]

@itsjeyd I'm volunteering to review PR. Could you please assign it to me?

[pdpinch]

Thank you @ziafazal!

[itsjeyd]

@ziafazal Of course, done! Thanks for volunteering.

[pdpinch]

After review by @ziafazal and changes from the author @asadali145, the PR has been merged!

I'm optimistic this will fix the issue, but we'll have to do some testing after deployment to our QA and production environments.

[antoviaque]

@pdpinch This is great news! :) Glad to hear it. I'll mark this ticket as closed for now, but don't hesitate to reopen it if needed.