patient_report.php bug from forum, appears on 5.0.0

[stephenwaite]

No description provided.

[stephenwaite]

https://community.open-emr.org/t/report-bug/9594?u=stephenwaite

[sssopen]

I can't reproduce this issue. Added screenshots on the forum:
https://community.open-emr.org/t/report-bug/9594/4

[stephenwaite]

hi @sssopen , it looks like it was done with the soap note form

[sssopen]

Hi stephenwaite,
I used SOAP notes in the encounters and still can't reproduce. Added new screenshots on the forum.

[stephenwaite]

thanks for diligently researching this bug @sssopen , @bradymiller miller has a nice point there that it shows up here

[stephenwaite]

then select the encounters and choose patient report

[sssopen]

Thanks. I found it and was able to recreate the issue. I will look into it.

[sssopen]

Hello experts,

This seems like a design issue. Encounters are created with the user specified date so I can create an encounter with the date 04/08/18 (current date 04/04/18). However, when we add a note (ex. SOAP) to an encounter we create the note with the current timestamp (04/04/18). When we pull the encounters and notes for the report with the below SQL, the resultset is giving the data the way report is being displayed. Do we really need to allow future dated encounters?

SELECT forms.encounter, forms.form_id, forms.form_name,
forms.formdir, forms.date AS fdate, form_encounter.date,form_encounter.reason
FROM forms, form_encounter
WHERE forms.pid =1 AND form_encounter.pid = 1 AND
form_encounter.encounter = forms.encounter AND forms.deleted=0
ORDER BY form_encounter.encounter DESC, form_encounter.date DESC, fdate ASC

[sssopen]

Taking another look at it and the code, the data retrieved should work. Seems like there is some mess in the code.

[sssopen]

Okay. I think I found the issue. Code is expecting to have records in particular a order. "New Patient Encounter" record come before the other notes in that encounter. However, that's not happening if you look at the SQL result:

Based on that resultset, the report output will be:

Either we make the code changes to resolve this issue or we make a change in SQL to return the data the way code is expecting. So making SQL could be easier. If I change the SQL ORDER BY:

SELECT forms.encounter, forms.form_id, forms.form_name,
forms.formdir, forms.date AS fdate, form_encounter.date,form_encounter.reason
FROM forms, form_encounter
WHERE forms.pid =2 AND form_encounter.pid = 2 AND
form_encounter.encounter = forms.encounter AND forms.deleted=0
ORDER BY form_encounter.date DESC, form_encounter.encounter DESC

//ORDER BY form_encounter.encounter DESC, form_encounter.date DESC, fdate ASC -- OLD

The results will be in the order the way code is expecting:

The report output will be correct, encounters will have their own notes:

[stephenwaite]

really nice research and explanation @sssopen , thank you
believe @bradymiller had suggested that we add a new feature that would enable a user to priortize the forms and how they appear in the encounter view and this could probably be extended to the report too

[bradymiller]

hi @sssopen ,

We should make sure that we don't reintroduce another bug that was fixed previously here:
#1015
(ie. it looks like things just got more complicated :) )

-brady

[sssopen]

Hi Brady,
Thanks for letting me know about #1015. I double checked. Seems like #1015 didn't completely fix the issue. If you look at the my above example closely, problem was still there that scenario.
I tested a few different scenarios and my fix seems to be working fine.

Let me know if I should push my change.

[bradymiller]

Sorry for the delay. Was travelling out of country for a bit. I received this info regarding this from somebody via email regarding this and fix 1015:
"Prior to fix encounters appear in reverse date order. Post fix the possibility exists that now they will not always appear this way. .."

[bradymiller]

hi @sssopen ,
Forgot to flag you on my post above. Also, if your interested, have been thinking of cool things we can do with the current menu customization features (completely unrelated to this and bug fixes; and would be a rather large project); let me know if your interested.

[sssopen]

Hi Brady
Just saw your messages. Yes, I am interested working on menu customization features. Thanks for checking with me.

[bradymiller]

@sssopen , just sent you an email :)

[kacyw]

@bradymiller is this still an issue?

[bradymiller]

I don't think so, but I honestly can't figure out if it is. Per the forum thread, it appears this is a non-issue:
https://community.open-emr.org/t/same-day-multiple-encounters-patient-report-bug/9594/13

@stephenwaite , any thoughts on this?

[bradymiller]

@kacyw , forgot to mention you on above post

[stephenwaite]

guess we should try to recreate the bug to see if it addresses @vrjulas original report, @epsdky has a Fermat like comment that leaves me mystified