Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified maintenance for service provider parameters #398

Closed
wants to merge 2 commits into from

Conversation

mdsupport
Copy link
Contributor

Single screen access and addresses #376

@sunsetsystems
Copy link
Member

Looking at this today... apologies for the delay.

@sunsetsystems
Copy link
Member

Doing a fresh install I see some issues right away.

  1. The widget is too small for its content and should not take up space when it's not being used.
  2. Protocol does not appear in the list.
  3. Aren't we using fancybox for modal dialogs? I don't like it much either, but we need to settle on a standard replacement for dlgopen() etc. and not re-invent it for each use case.

@sunsetsystems
Copy link
Member

Sorry I should have included this screenshot.
screenshot at 2017-01-05 13-37-34

@mdsupport
Copy link
Contributor Author

  1. Needed bootstrap css - we have that as standard in all styles.
  2. Needed font-awesome css - we have that as standard in all styles.
  3. There is no need for a dialog when that content can be displayed inline.

@sunsetsystems
Copy link
Member

That's much better, looks very nice! I'm not seeing any issues. Just need to deal with the branch conflicts.

@sunsetsystems
Copy link
Member

Noticed one bug... if you choose to edit a provider then cancel the iframe, the provider line remains highlighted. It should go back to normal as it does when you save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants