Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib version #3

Open
anthonator opened this issue May 31, 2014 · 2 comments
Open

zlib version #3

anthonator opened this issue May 31, 2014 · 2 comments

Comments

@anthonator
Copy link

What version of zlib is preferred for FCEU-Core? I've tried 1.2.8 and it seems too new. Compiling throws the following errors:

src-fceumm/file.c:171:20: error: member reference base type 'void' is not a structure or union
  for(tmp->size=0; gzgetc(tz) != EOF; tmp->size++);
                   ^~~~~~~~~~
./utils/zlib/zlib.h:1682:15: note: expanded from macro 'gzgetc'
          ((g)->have ? ((g)->have--, (g)->pos++, *((g)->next)++) : gzgetc(g))
           ~~~^ ~~~~

When you look at gzgetc it doesn't seem to like passing void as an option since 1.2.4.

I'd be happy to submit PR's to support new versions of zlib if that would be helpful.

@anthonator
Copy link
Author

Switching to zlib 1.2.3 does fix the issue.

@mrvacbob
Copy link
Contributor

mrvacbob commented Jun 3, 2014

The system zlib. If it's reading local copies of zlib (or headers) instead of the system ones they should be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants