Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests for ELF enclave on Windows #1033

Closed
CodeMonkeyLeet opened this issue Nov 7, 2018 · 9 comments
Closed

Re-enable tests for ELF enclave on Windows #1033

CodeMonkeyLeet opened this issue Nov 7, 2018 · 9 comments
Assignees
Labels
testing Issue has to do with testing or quality management windows Issue has to do with supporting Open Enclave on Windows
Milestone

Comments

@CodeMonkeyLeet
Copy link
Contributor

CodeMonkeyLeet commented Nov 7, 2018

Prior to PR #632, many more tests were enabled for running ELF enclaves on Windows. This issue tracks re-enabling these tests and fixing any new build breaks and issues introduced into them while they were disabled:

  • abortStatus
  • create-rapid
  • ecall_ocall
  • echo
  • enclaveparam
  • cppException
  • getenclave
  • hostcalls
  • hexdump
  • initializers
  • libc
  • libcxx
  • libcxxrt
  • memory
  • mixed_c_cpp
  • ocall
  • ocall-create
  • print
  • report
  • SampleApp
  • SampleAppCRT
  • sealKey
  • stdcxx
  • thread
  • threadcxx

In addition, we should also evaluate enabling tests that were previously not enabled due to a dependency on oegen which has since been replaced by oeedger8r that has been enabled to run on Windows by PR #895:

  • file
  • pingpong
  • pingpong-shared
@CodeMonkeyLeet CodeMonkeyLeet added testing Issue has to do with testing or quality management windows Issue has to do with supporting Open Enclave on Windows labels Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet changed the title Re-enable ELF enclave on Windows tests Re-enable tests for ELF enclave on Windows Nov 7, 2018
@lilyfang lilyfang assigned yakman2020 and anitagov and unassigned yakman2020 and anitagov Nov 10, 2018
@anitagov
Copy link
Contributor

Enabled 16 ELF enclaves on Windows with my PR #1173

@anitagov
Copy link
Contributor

anitagov commented Dec 19, 2018

Enabled 6 more tests with PR #1217

@anitagov anitagov self-assigned this Jan 1, 2019
@anitagov
Copy link
Contributor

anitagov commented Jan 4, 2019

Enabled 2 more tests (cppException and sealKey) with PR #1280

@anitagov
Copy link
Contributor

anitagov commented Jan 5, 2019

PR #1289 - Enabled abortStatus for Windows after resizing ELF enclave and bypassing the result from terminate_enclave.

@anitagov
Copy link
Contributor

Please look at my issue #1008 for tests that have been enabled. I am also updating this issue to keep in synch.

@anitagov
Copy link
Contributor

anitagov commented Feb 6, 2019

Enabled mbed tests for Windows with my PR #1372 .
Disabled ecall_ocall for Windows as it intermittently fails with my PR #1415 .

@anitagov
Copy link
Contributor

anitagov commented Feb 6, 2019

The current list of tests that are not enabled on Windows are:
create-rapid
crypto_crls_cert_chains
ecall_ocall - Was enabled and recently pulled out due to size issues on Windows
libcxx
libcxxrt
libunwind
memory
qeidentity - Attestation is not supported on Windows yet
report - Attestation is not supported on Windows yet

@CodeMonkeyLeet CodeMonkeyLeet moved this from Backlog to Priority Queue in Windows Support Mar 21, 2019
@anitagov anitagov added this to the v0.6 milestone Mar 21, 2019
@anitagov
Copy link
Contributor

libc tests were enabled on Windows with PR #1508

@yakman2020 yakman2020 modified the milestones: v0.6, v0.7 Jun 25, 2019
@CodeMonkeyLeet
Copy link
Contributor Author

Closing this as outdated and tracking remaining tests as part of parent epic #39 directly.

Windows Support automation moved this from In Progress Issues to Done Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issue has to do with testing or quality management windows Issue has to do with supporting Open Enclave on Windows
Projects
No open projects
Development

No branches or pull requests

3 participants