Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Open Enclave SDK package configuration #301

Closed
2 tasks done
CodeMonkeyLeet opened this issue Jun 9, 2018 · 2 comments
Closed
2 tasks done

Update Open Enclave SDK package configuration #301

CodeMonkeyLeet opened this issue Jun 9, 2018 · 2 comments
Labels
functionality Issue describes an enhancement or addition of functionality to Open Enclave SDK
Milestone

Comments

@CodeMonkeyLeet
Copy link
Contributor

CodeMonkeyLeet commented Jun 9, 2018

This issue tracks updating the Open Enclave SDK package configuration before publishing it for Public Preview. This is a prerequisite for #48.

Per @mikbras:

Change install directory to /opt/openenclave. Currently OE installs under /usr/local/*, which puts our
components on the default path. The samples were working on my machine and failing on Anita’s
machine because they were finding /usr/local/bin/oegen rather than the one in our build directory.
Most Microsoft projects place these kinds of tools under /opt for this reason.

mikras> After further consideration, I would leave the install prefix as /usr/local. If we don't install here, the user will have to manage:

  • PATH
  • PGK_CONFIG_PATH
  • The search path for libraries.

Also note that some of the paths in the source tree are not fully pathed, so the developer will encounter certain problems (like depending on the installed version of oesign rather than the version in the source tree).

Other changes in this vein:

  • Remove oegen and other internal tools from being published
  • Remove internal headers from being published
@CodeMonkeyLeet CodeMonkeyLeet added this to Backlog in Public preview via automation Jun 9, 2018
@CodeMonkeyLeet CodeMonkeyLeet added this to the 2018.08 milestone Jun 9, 2018
@CodeMonkeyLeet CodeMonkeyLeet added the story Issue describes a user scenario to be enabled. Unit of prioritization for project planning. label Jun 9, 2018
@herveyw-msft
Copy link
Contributor

herveyw-msft commented Jun 20, 2018

@CodeMonkeyLeet This seems wrong to me, especially just to fix a build problem. The file system standard says /usr/local is for administrator installed packages, /opt is for optional packages.

@CodeMonkeyLeet CodeMonkeyLeet added functionality Issue describes an enhancement or addition of functionality to Open Enclave SDK and removed story Issue describes a user scenario to be enabled. Unit of prioritization for project planning. labels Jun 27, 2018
@CodeMonkeyLeet CodeMonkeyLeet modified the milestones: 2018.08, 2018.09 Sep 5, 2018
@CodeMonkeyLeet CodeMonkeyLeet modified the milestones: 2018.09, 2018.10 Oct 2, 2018
@CodeMonkeyLeet
Copy link
Contributor Author

Resolved, also see additional cleanup PRs #863 and #867 for the v0.4.0 SDK release

Public preview automation moved this from Backlog to Done Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functionality Issue describes an enhancement or addition of functionality to Open Enclave SDK
Projects
No open projects
Development

No branches or pull requests

2 participants