Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of the Werror flag for building samples between Linux and Windows #3773

Open
mingweishih opened this issue Dec 8, 2020 · 2 comments · May be fixed by #3816
Open

Inconsistent use of the Werror flag for building samples between Linux and Windows #3773

mingweishih opened this issue Dec 8, 2020 · 2 comments · May be fixed by #3816
Assignees
@mingweishih
Labels
build Issue is related to the build system samples Tag indicating association with the Open Enclave SDK samples. triaged This label classifies an issue/PR as having been triaged.
Projects
v0.19
Milestone
v0.19

Comments

@mingweishih
Copy link
Collaborator

When building samples on Windows, the maybe_build_using_clangw adds the Werror flag, which results in treating warnings as errors.

openenclave/samples/helloworld/enclave/CMakeLists.txt

Line 16 in eaa3608

maybe_build_using_clangw(enclave)

openenclave/cmake/maybe_build_using_clangw.cmake

Line 57 in eaa3608

-Werror

This is inconsistent with Linux setting where we didn't add the Werror flag (we only enforce it for the building OE libraries and tests).
@dthaler dthaler added samples Tag indicating association with the Open Enclave SDK samples. build Issue is related to the build system labels Dec 14, 2020
@dthaler
Copy link
Contributor

dthaler commented Dec 14, 2020

Seems like we should use it for both

@radhikaj
Copy link
Contributor

Lets change Linux to match Windows

@radhikaj radhikaj added this to the Backlog milestone Dec 14, 2020
@radhikaj radhikaj added the triaged This label classifies an issue/PR as having been triaged. label Dec 14, 2020
@mingweishih mingweishih linked a pull request Feb 2, 2021 that will close this issue
Open
@mingweishih mingweishih added this to In progress in v0.16 Feb 9, 2021
@mingweishih mingweishih moved this from In progress to Under review in v0.16 Feb 11, 2021
@radhikaj radhikaj added this to Under Review in v0.17 May 26, 2021
@radhikaj radhikaj removed this from Under review in v0.16 May 26, 2021
@radhikaj radhikaj removed this from Under Review in v0.17 Jun 21, 2021
@radhikaj radhikaj added this to To do in v0.18 via automation Jun 21, 2021
@radhikaj radhikaj modified the milestones: Backlog, v0.18 Jun 21, 2021
@radhikaj radhikaj removed this from To do in v0.18 Jun 6, 2022
@radhikaj radhikaj added this to To do in v0.19 via automation Jun 6, 2022
@radhikaj radhikaj modified the milestones: v0.18, v0.19 Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mingweishih mingweishih

Labels
build Issue is related to the build system samples Tag indicating association with the Open Enclave SDK samples. triaged This label classifies an issue/PR as having been triaged.
Projects
v0.19
To do
Milestone
v0.19
Development

Successfully merging a pull request may close this issue.

Enforce Werror when building samples on Linux mingweishih/openenclave
3 participants
@radhikaj @dthaler @mingweishih