Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify enclave tests by relying on debug test signing #465

Closed
CodeMonkeyLeet opened this issue Jul 25, 2018 · 0 comments
Closed

Simplify enclave tests by relying on debug test signing #465

CodeMonkeyLeet opened this issue Jul 25, 2018 · 0 comments
Labels
engineering Issue is related to tools and processes necessary for maintaining the Open Enclave repo testing Issue has to do with testing or quality management
Projects
Public preview

Comments

@CodeMonkeyLeet
Copy link
Contributor

With the implementation of #160, tests that only need to run in debug can declare the OE_SET_ENCLAVE_SGX properties instead of keeping private.pem signing keys and sign.conf around which reduces the amount of bloat in the codebase.

This should wait until we solve #346 to do this cleanup since the enclave properties depend on NOTE sections currently, which is why this is split off from #57 as a separate task.
@CodeMonkeyLeet CodeMonkeyLeet added testing Issue has to do with testing or quality management engineering Issue is related to tools and processes necessary for maintaining the Open Enclave repo labels Jul 25, 2018
@CodeMonkeyLeet CodeMonkeyLeet added this to Backlog in Public preview via automation Jul 25, 2018
@CodeMonkeyLeet CodeMonkeyLeet mentioned this issue Jul 25, 2018
Closed
10 tasks
@anakrish anakrish mentioned this issue Sep 5, 2018
Merged
@anakrish anakrish moved this from Backlog to Priority Queue in Public preview Sep 5, 2018
@anakrish anakrish moved this from Priority Queue to In progress in Public preview Sep 5, 2018
@anakrish anakrish moved this from In progress to In review in Public preview Sep 5, 2018
@anakrish anakrish moved this from In review to Done in Public preview Sep 5, 2018
@anakrish anakrish closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering Issue is related to tools and processes necessary for maintaining the Open Enclave repo testing Issue has to do with testing or quality management
Projects
No open projects
Public preview
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CodeMonkeyLeet @anakrish