Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmonHubTeslaPowerWallInterfacer.py in branch emon-pi is different to the master or stable versions #119

Closed
borpin opened this issue Jul 5, 2020 · 1 comment
Closed

EmonHubTeslaPowerWallInterfacer.py in branch emon-pi is different to the master or stable versions #119

borpin opened this issue Jul 5, 2020 · 1 comment

Comments

@borpin
Copy link
Contributor

borpin commented Jul 5, 2020

SSL not in master

https://github.com/openenergymonitor/emonhub/blob/emon-pi/src/interfacers/EmonHubTeslaPowerWallInterfacer.py
@borpin borpin changed the title EmonHubTeslaPowerWallInterfacer.py is different to the master or stable versions EmonHubTeslaPowerWallInterfacer.py in branch emon-pi is different to the master or stable versions Jul 5, 2020
@borpin
Copy link
Contributor Author

borpin commented Jul 5, 2020

In addition, it imports urllib2 which is not installed.

I note urllib3 is available from apt but https://stackoverflow.com/questions/2018026/what-are-the-differences-between-the-urllib-urllib2-urllib3-and-requests-modul suggests that requests is used instead.

I note requests is used by other Interfacers.

@borpin borpin closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@borpin