Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

UI options for different notifications (errors, warnings, info) #331

Open
ltfschoen opened this issue Jan 3, 2019 · 2 comments
Open

UI options for different notifications (errors, warnings, info) #331

ltfschoen opened this issue Jan 3, 2019 · 2 comments

Comments

@ltfschoen
Copy link
Contributor

ltfschoen commented Jan 3, 2019

Raised in discussion here #327 (comment)

Currently for form validation errors we validate input form field values and use the react-final-form library to display errors as black tooltips over the relevant field with the issue so the user can pinpoint what needs to be fixed.

But some notifications are shown in a paragraph at the bottom, such as in AccountImportOptions.js, (i.e. 'The passphrase was not recognized ..., etc) and TxForm.js (i.e. WARNING: The sender and receiver addresses are the same.).

We also have other kinds of notifications (i.e. RequireHealthOverlay currently shows connection notifications to a user via a modal, and in future we could introduce push notifications or similar)

We are adopting SUI components using Semantic UI and with styled-components as a standard.
Which of the following should we use? Could we just use toasters like Semantic UI Alert or similar for all notifications? Answer: Not for all notifications, see requirements mentioned in this thread

Semantic UI has:

Alternative notification libraries include:

@Tbaut
Copy link
Collaborator

Tbaut commented Jan 3, 2019

I like the tool-tips for TxForm errors because they mention where the problem is. I think we could use a simple SUI alert showed for 5s for warning and global errors.
idea:

image

(i.e. 'The passphrase was not recognized ..., etc)

This should be a tool tip IMO. Will create an issue for that.
edit: it also makes sense for import errors

Warning (e.g for self sent ETH for instance) could be displayed in a similar manner

image

@Tbaut Tbaut added this to the 0.4 milestone Jan 3, 2019
@ltfschoen
Copy link
Contributor Author

Note the following requirements clarified in this discussion #326 (comment)

When there's a bad connection, Parity's downloading, or there's no internet, or there's no peers, or it's syncing, then these are the requirements:

  • Show a full modal on all screens that read/write blockchain state: tokens balances, send tx, etc.
  • Don't show a modal on other screens (account management), only a green/yellow/red button

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants