Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ConfirmationRequest enum has two identically-named fields #3560

Closed
krl opened this issue Nov 21, 2016 · 0 comments
Closed

ConfirmationRequest enum has two identically-named fields #3560

krl opened this issue Nov 21, 2016 · 0 comments
Assignees
@tomusdrw
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Comments

@krl
Copy link
Contributor

krl commented Nov 21, 2016

https://github.com/ethcore/parity/blob/master/rpc/src/v1/types/confirmations.rs#L106

This breaks Deserialization

Right, I did it to keep compatibility with the UI, cause the UI doesn't care which case is it.
We can rename it, but we need handle both cases in the UI too.
-- @tomusdrw
@krl krl mentioned this issue Nov 21, 2016
Closed
3 tasks
@tomusdrw tomusdrw added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Nov 22, 2016
@tomusdrw tomusdrw self-assigned this Nov 25, 2016
@tomusdrw tomusdrw mentioned this issue Nov 28, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomusdrw tomusdrw

Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krl @tomusdrw