Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Random Signer confirm/reject error pop-up #3570

Closed
jacogr opened this issue Nov 22, 2016 · 3 comments
Closed

Random Signer confirm/reject error pop-up #3570

jacogr opened this issue Nov 22, 2016 · 3 comments
Labels
F2-bug 🐞 The client fails to follow expected behavior. Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known.

Comments

@jacogr
Copy link
Contributor

jacogr commented Nov 22, 2016

parity 2016-11-22 13-25-09
parity 2016-11-22 13-23-59

@jacogr jacogr added F2-bug 🐞 The client fails to follow expected behavior. M7-ui labels Nov 22, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 23, 2016

could be from finding the request in the pending queue in the reducer -

signerSuccessConfirmRequest (state, action) {
    const { id, txHash } = action.payload;
    const confirmed = Object.assign(
      state.pending.find(p => p.id === id),
      { result: txHash, status: 'confirmed' }
    );

    return {
      ...state,
      pending: removeWithId(state.pending, id),
      finished: [confirmed].concat(state.finished)
    };
  }

i.e. state.pending.find - really no proper insight at this time

@ngotchac ngotchac added the Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. label Dec 27, 2016
@ngotchac
Copy link
Contributor

Should be fixed from #3804

@ngotchac
Copy link
Contributor

Should definitely be fixed with #3990

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior. Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known.
Projects
No open projects
User Interface
Done (1.5.0)
Development

No branches or pull requests

2 participants