Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Improve verifier scaling algorithm #3708

Closed
rphmeier opened this issue Dec 2, 2016 · 6 comments
Closed

Improve verifier scaling algorithm #3708

rphmeier opened this issue Dec 2, 2016 · 6 comments
Labels
F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Dec 2, 2016

@keorn suggested a PID controller, but it seems a bit overkill. Somewhere in the middle of current complexity and that would be nice.

Update time should also be reduced, once a minute is far too long.

@rphmeier rphmeier added F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. M4-core ⛓ Core client code / Rust. labels Dec 2, 2016
@rphmeier rphmeier added this to the 1.5 Tenuity milestone Dec 2, 2016
@rphmeier rphmeier self-assigned this Dec 2, 2016
@rphmeier rphmeier removed this from the 1.5 Tenuity milestone Dec 2, 2016
@5chdn
Copy link
Contributor

5chdn commented May 16, 2017

This optimization labelled issue is inactive since last year.

@paritytech/core-devs Please, confirm within 7 days if this is still relevant. If so, please comment below and add an assignee, or close it otherwise.

@rphmeier
Copy link
Contributor Author

yes, i'd say it's still relevant. will probably revisit it fairly soon, but have been focusing on other things.

@5chdn 5chdn added the P7-nicetohave 🐕 Issue is worth doing eventually. label Sep 4, 2017
@5chdn 5chdn added this to the 1.10 & ... milestone Oct 5, 2017
@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@folsen
Copy link
Contributor

folsen commented May 19, 2018

I can't really even make out what this means, @rphmeier if you have a more specific proposal that someone else could pick up, please reopen with that description.

@folsen folsen closed this as completed May 19, 2018
@rphmeier
Copy link
Contributor Author

This is about the --scale-verifiers flag which activates threads for parallel ethash verification dynamically.

@folsen
Copy link
Contributor

folsen commented May 21, 2018

Reopening as it might actually be some amount of boost in performance if we could parallelise more/better.

@folsen folsen reopened this May 21, 2018
@folsen folsen added this to Larger Projects in Core May 21, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Jul 17, 2018
@5chdn 5chdn added this to the 2.3 milestone Sep 27, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Oct 29, 2018
@5chdn 5chdn removed this from the 2.4 milestone Jan 10, 2019
@5chdn 5chdn added this to the 2.5 milestone Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.5, 2.6 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.6, 2.7 Apr 2, 2019
@debris
Copy link
Collaborator

debris commented Jul 7, 2019

I'm closing as this is not a priority right now and will not be in a foreseeable future

@debris debris closed this as completed Jul 7, 2019
@vorot93 vorot93 removed this from Larger Projects in Core Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

5 participants