Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Multi-sig contract does not send any amount on Ethereum Classic #4057

Closed
SyRenity opened this issue Jan 5, 2017 · 18 comments
Closed

Multi-sig contract does not send any amount on Ethereum Classic #4057

SyRenity opened this issue Jan 5, 2017 · 18 comments
Assignees
Labels
F2-bug 🐞 The client fails to follow expected behavior. Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known.

Comments

@SyRenity
Copy link

SyRenity commented Jan 5, 2017

After the UI problem has been fixed, I tested the multi-sig sending both on ETH and on ETC.

On ETH it works fine, on ETC the contract doesn't actually send anything, despite being signed by minimum amount of co-signers, and the sign request disappearing from Parity UI.
http://gastracker.io/addr/0x677c0cca27b705b59d13a6ffd419bec3ef0a8cd8

@SyRenity
Copy link
Author

SyRenity commented Jan 5, 2017

@ngotchac Seems ETH contract code not working correctly under ETC for some reason?

@SyRenity SyRenity changed the title Multi-sig contract is sending 0 amount on Ethereum Classic Multi-sig contract does not send any amount on Ethereum Classic Jan 5, 2017
@SyRenity
Copy link
Author

SyRenity commented Jan 5, 2017

Attached is the screenshot of parity after the sending attempt.
etc multi-sig

@ngotchac ngotchac added F2-bug 🐞 The client fails to follow expected behavior. M7-ui labels Jan 5, 2017
@ngotchac
Copy link
Contributor

ngotchac commented Jan 5, 2017

@SyRenity It seems that a lot of transactions have failed due to gas estimation issues (eg. http://gastracker.io/tx/0x41720e414e29b63916656facdb2813f0abc14ca05d9610c84d6ab5f1db7103bb)

Could you try to resend those transactions increasing the supplied gas amount (from the Edit Gas button in the signer, before signing the transaction). Gas estimation might sometime be a little off...

@SyRenity
Copy link
Author

SyRenity commented Jan 5, 2017

@ngotchac The transactions indeed failed until I've manually increased to a quite large value, and then they went through for remaining 2 co-signers. The contract unfortunately never performed any sending afterwards (compared to the Eth one).

@ngotchac
Copy link
Contributor

ngotchac commented Jan 6, 2017

@SyRenity It seems that the created transaction (http://gastracker.io/tx/0x186d0790809ebca2a12b89e924ed87b0527654d45160ba45f86119f4dfdf4360) had the wrong input, because it tried to send 0x10da15446e63d1e6169deb000000000 wei, which is about 1,400,000,000,000,000,000 eth (quite a bit more than the balance aha). It might be an error in the Transfer source code, but that should be fixed. Could you try to build from master once again?

@ngotchac ngotchac added the Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. label Jan 6, 2017
@SyRenity
Copy link
Author

SyRenity commented Jan 6, 2017

@ngotchac Sure, should I redeploy a new multi-sig contract as well?

@ngotchac
Copy link
Contributor

ngotchac commented Jan 7, 2017

I don't think so, you shouldn't have to at least

@SyRenity
Copy link
Author

SyRenity commented Jan 8, 2017

@ngotchac Tried this again, unfortunately it didn't work:
http://gastracker.io/addr/0x677c0ccA27B705b59D13a6ffd419BeC3ef0a8CD8

You can see that the transactions went fine, but the contract was stll not executed.

So, would it be a good idea to redploy?

@ngotchac
Copy link
Contributor

ngotchac commented Jan 9, 2017

Something is wrong on our side on how we convert the user input to actually token/wei value. A PR is out (#4098) that would maybe fix that. If not, some logging info will be available for an easier debug...

@SyRenity
Copy link
Author

@ngotchac Will specifying higher gas limit help with that? I tried up to 999999 with the same result.

@ngotchac
Copy link
Contributor

No, unfortunately the issue is that the UI creates a transaction with the wrong info (the amount has too many zeros basically)

@ngotchac ngotchac self-assigned this Jan 10, 2017
@ngotchac
Copy link
Contributor

@SyRenity You should be able to try again, after having built master. If it still doesn't work, please copy and paste this in the JS console:

window.localStorage.setItem('loglevel:modals/Transfer/store', 'TRACE');

This will add more logging/debugging. Then try again from scratch to send some eth, and share the logs printed in the console, that would help greatly !

@SyRenity
Copy link
Author

SyRenity commented Jan 10, 2017

Then try again from scratch to send some eth

@ngotchac Just to be on same page, we speak about ETC (ETH works just fine).

@ngotchac
Copy link
Contributor

Ok so I just tried with ETC, and everything works fine on my end... So I would suggest to try to again with the extras logging enabled as described above (will only work on latest master), and share those logs....

@SyRenity
Copy link
Author

SyRenity commented Jan 12, 2017

@ngotchac In the latest master the transaction never sent (despite setting a high gas of 999999), the UI shows the error "the transaction will throw an exception with the current values", and the console logs the following errors:

index.c451ba0572.js:11 eth_estimateGas([{"to":"0x677c0cca27b705b59d13a6ffd419bec3ef0a8cd8","from":"0x0675c8d905fc2bf5d95e6f703e31e0dad84a184b","gas":"0x2faf080","data":"0xb61d27f600000000000000000000000000a41e254d371dd2b2b2ecfe693c8c4f51c0e4b6000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000"}]): -32015: Transaction execution error.
a._onMessage @ index.c451ba0572.js:11
index.c451ba0572.js:10 execute.estimateGas ["0x00a41e254d371dD2b2B2eCfe693c8C4f51C0e4B6", t, ""] t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}
(anonymous) @ index.c451ba0572.js:10
index.c451ba0572.js:17 etimateGas t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}
(anonymous) @ index.c451ba0572.js:17
index.c451ba0572.js:11 eth_estimateGas([{"to":"0x677c0cca27b705b59d13a6ffd419bec3ef0a8cd8","from":"0x0675c8d905fc2bf5d95e6f703e31e0dad84a184b","gas":"0x2faf080","data":"0xb61d27f600000000000000000000000000a41e254d371dd2b2b2ecfe693c8c4f51c0e4b6000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000"}]): -32015: Transaction execution error.
a._onMessage @ index.c451ba0572.js:11
index.c451ba0572.js:10 execute.estimateGas ["0x00a41e254d371dD2b2B2eCfe693c8C4f51C0e4B6", t, ""] t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}
(anonymous) @ index.c451ba0572.js:10
index.c451ba0572.js:17 etimateGas t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}
(anonymous) @ index.c451ba0572.js:17
index.c451ba0572.js:11 eth_estimateGas([{"to":"0x677c0cca27b705b59d13a6ffd419bec3ef0a8cd8","from":"0x0675c8d905fc2bf5d95e6f703e31e0dad84a184b","gas":"0x2faf080","data":"0xb61d27f600000000000000000000000000a41e254d371dd2b2b2ecfe693c8c4f51c0e4b6000000000000000000000000000000000000000000000000136dcc951d8c000000000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000"}]): -32015: Transaction execution error.
a._onMessage @ index.c451ba0572.js:11
index.c451ba0572.js:10 execute.estimateGas ["0x00a41e254d371dD2b2B2eCfe693c8C4f51C0e4B6", t, ""] t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}
(anonymous) @ index.c451ba0572.js:10
index.c451ba0572.js:17 etimateGas t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}
(anonymous) @ index.c451ba0572.js:17
index.c451ba0572.js:11 eth_estimateGas([{"to":"0x677c0cca27b705b59d13a6ffd419bec3ef0a8cd8","from":"0x0675c8d905fc2bf5d95e6f703e31e0dad84a184b","gas":"0x2faf080","data":"0xb61d27f600000000000000000000000000a41e254d371dd2b2b2ecfe693c8c4f51c0e4b6000000000000000000000000000000000000000000000000136dcc951d8c000000000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000"}]): -32015: Transaction execution error.
a._onMessage @ index.c451ba0572.js:11
index.c451ba0572.js:10 execute.estimateGas ["0x00a41e254d371dD2b2B2eCfe693c8C4f51C0e4B6", t, ""] t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}
(anonymous) @ index.c451ba0572.js:10
index.c451ba0572.js:17 etimateGas t {code: -32015, type: "EXECUTION_ERROR", method: "eth_estimateGas", text: "Transaction execution error.", message: "eth_estimateGas: -32015: Transaction execution error."…}

@ngotchac
Copy link
Contributor

ngotchac commented Jan 13, 2017

@SyRenity This should have been fixed via #4165 (now on master)

@SyRenity
Copy link
Author

@ngotchac Confirmed, ETC sending works fine now :).

@ngotchac
Copy link
Contributor

Great, thanks for taking the time to test !!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior. Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known.
Projects
No open projects
User Interface
Done (1.5.0)
Development

No branches or pull requests

2 participants