Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

UI: Badge fail showing up for the first row #7337

Closed
chevdor opened this issue Dec 19, 2017 · 4 comments
Closed

UI: Badge fail showing up for the first row #7337

chevdor opened this issue Dec 19, 2017 · 4 comments
Assignees
Labels
F2-bug 🐞 The client fails to follow expected behavior.
Milestone

Comments

@chevdor
Copy link

chevdor commented Dec 19, 2017

I'm running:

  • Which Parity version?: Parity/v1.9.0-unstable-fcddc7751-20171208/x86_64-macos/rustc1.22.1
  • Which operating system?: Windows / MacOS / Linux
  • How installed?: via installer / homebrew / binaries / from source
  • Are you fully synchronized?: no / yes
  • Did you try to restart the node?: no / yes

Hi @jacogr :)

The issue is not very simple to reproduce:

  • You will need at least 4 accounts (I tested with 10).
  • All the accounts should have the same tag.
  • All the accounts should have a given Badge.

Now filter using the tag.

The result list should show you more than 1 row, each row with 3 results.

The issue is that in the first row, the Badge never shows up on the account.
If you click the account to see the details, you will see the badge. If you change the sorting of the list, you will see that it is always the first row that misses the Badge display.

This may be related to #7333 and its recent fix.

@chevdor
Copy link
Author

chevdor commented Dec 19, 2017

As far as I see, you can even see the issue without applying tags and filtering.

@chevdor chevdor changed the title UI: Badge fail showing up under certain conditions UI: Badge fail showing up for the first row Dec 19, 2017
@tomusdrw tomusdrw added M7-ui Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. labels Dec 27, 2017
@tomusdrw
Copy link
Collaborator

@jacogr can you have a look?

@5chdn 5chdn added this to the 1.9 milestone Jan 2, 2018
@jacogr jacogr added this to Next Up in User Interface Jan 3, 2018
@jacogr jacogr moved this from Next Up to In Progress in User Interface Jan 4, 2018
@jacogr jacogr added F2-bug 🐞 The client fails to follow expected behavior. and removed Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. labels Jan 4, 2018
@jacogr
Copy link
Contributor

jacogr commented Jan 4, 2018

Ok, this is a weird one, but definately exists,

@jacogr jacogr self-assigned this Jan 4, 2018
@jacogr
Copy link
Contributor

jacogr commented Jan 4, 2018

@chevdor Could you try this branch - #7454

(Build with cargo build --release --no-default-features --features ui)

The reason for asking is that the changed I made (which was actually just cleanups as I went though), made it "just start working". As it stands the issue is weird since the rows have no significance on the display anyway, each indv. card gets handled on it's own.

@jacogr jacogr moved this from In Progress to In Review in User Interface Jan 4, 2018
@jacogr jacogr moved this from In Review to 1.9.0 in User Interface Jan 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior.
Projects
No open projects
Development

No branches or pull requests

4 participants