Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-1380: Paragraph field bare template suggestion should not depend on oe_bootstrap_theme_paragraphs #221

Closed
claudiu-cristea opened this issue Mar 29, 2022 · 1 comment

Comments

@claudiu-cristea
Copy link
Contributor

claudiu-cristea commented Mar 29, 2022

Problem

In 9a44fe1, the field__bare suggestion was moved from the theme to oe_bootstrap_theme_paragraphs sub-module. The oe_bootstrap_theme_paragraphs sub-module is designed to bridge between oe_bootstrap_theme and oe_paragraphs module. But this is not the case for all projects. Some projects, such as Joinup, are using the paragraphs module without depending on oe_paragraphs. The change from 9a44fe1 did introduce a regression when we updated OE Bootstrap Theme from an early version to 1.0.0-alpha7.

Proposal

Move back (revert) the suggestion alter to includes/field.inc so that all projects can benefit for this template suggestion, even they are not using oe_paragraphs.

@claudiu-cristea claudiu-cristea changed the title Paragraph fields bare template suggestion should not depend on oe_bootstrap_theme_paragraphs OEL-1380: Paragraph field bare template suggestion should not depend on oe_bootstrap_theme_paragraphs Mar 29, 2022
@brummbar
Copy link
Contributor

We decided to not offer this in oe_bootstrap_theme anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants