Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML tags are visible using bcl_card_list Twig Filter #330

Closed
serotonine opened this issue May 11, 2023 · 1 comment
Closed

HTML tags are visible using bcl_card_list Twig Filter #330

serotonine opened this issue May 11, 2023 · 1 comment

Comments

@serotonine
Copy link

serotonine commented May 11, 2023

Solution:
Wrap the text into the Drupal\Core\Render\Markup::create() method.
Proposed patch :
#329

@brummbar
Copy link
Contributor

Never use Markup::create() on content, especially on something that can be entered by editors.
Since the issue lacks information on how the data is being injected, I can only deduce from the ELA ticket that the content of a field was directly outputted to the card field instead of having something like

'#type' => 'processed_text',
'#text' => '<p>the text</p>',
'#format' => 'the_format',

So the suggested solution not only is wrong but also very dangerous. See #362 video at the bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants