Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV Portal Video is not sized correctly in featured media pattern #358

Closed
kp77 opened this issue Oct 26, 2023 · 1 comment
Closed

AV Portal Video is not sized correctly in featured media pattern #358

kp77 opened this issue Oct 26, 2023 · 1 comment

Comments

@kp77
Copy link
Contributor

kp77 commented Oct 26, 2023

The AV Portal Video media output contains the default field wrapper. This prevents the .ratio .ratio-16x9 classes to apply the correct sizing styles to the video iframe.

Screenshot 2023-10-26 at 09 58 58

I'm reporting it here, because OE Bootstrap Theme ships those field template overrides that remove the field wrapper from media types (for example: remote video).

Proposed solution: a similar override should be added extending field--bare.html.twig as
templates/overrides/field/field--media--av-portal-video.html.twig

OE Bootsrap Theme version: 1.7.0
OE Whitelabel version: 1.3.0

@brummbar
Copy link
Contributor

This does not belong here though, oe_bootstrap_theme doesn't integrate with components. There are some for legacy reason, but they are wrong. They should be in oe_whitelabel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants