Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RibbonClient doesn't support HTTPS #183

Closed
bstick12 opened this issue Feb 12, 2015 · 0 comments
Closed

RibbonClient doesn't support HTTPS #183

bstick12 opened this issue Feb 12, 2015 · 0 comments

Comments

@bstick12
Copy link
Contributor

Using the following test - https://gist.github.com/bstick12/2a21ffd30b14ec68716f#file-ribbonclienttest

You will see the following exception raised in the logs

21:04:25.583 [pool-1-thread-2] DEBUG c.n.l.LoadBalancerExecutor - Got error java.net.SocketException: Unexpected end of file from server when executed on server api.github.com:443

This is due to the request being made to http://api.github.com:443/.

The URI created in RibbonClient does include a scheme and eventually com.netflix.loadbalancer.LoadBalancerContext.deriveSchemeAndPortFromPartialUri(URI) will default the scheme to http.
bstick12 added a commit to bstick12/feign that referenced this issue Feb 12, 2015
@bstick12
Retain scheme in LBClient.RibbonRequest URI - fixes OpenFeign#183
fa9fcb6
@bstick12 bstick12 mentioned this issue Feb 12, 2015
Closed
bstick12 added a commit to bstick12/feign that referenced this issue Feb 14, 2015
@bstick12
Retain scheme in LBClient.RibbonRequest URI - fixes OpenFeign#183
5ec958d
@bstick12 bstick12 mentioned this issue Feb 18, 2015
Closed
codefromthecrypt pushed a commit that referenced this issue Feb 19, 2015
@bstick12
Retains scheme in LBClient.RibbonRequest URI
9379a66 
Before this change, we were dropping scheme, which prevented use of https.

closes #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bstick12