Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need to specify overrides = true #39

Closed
codefromthecrypt opened this issue Aug 4, 2013 · 1 comment
Closed

Remove need to specify overrides = true #39

codefromthecrypt opened this issue Aug 4, 2013 · 1 comment

Comments

@codefromthecrypt
Copy link
Contributor

When Module(overrides=true) is set, any @Provides(type = SET) methods will override as opposed to adding to ones specified by feign.

This leads to hacks inside ReflectiveFeign like below, which manually enforce a base set of decoders. These cannot be overridden by dagger at all.

      this.decoders.put(void.class, stringDecoder);
      this.decoders.put(Response.class, stringDecoder);
      this.decoders.put(String.class, stringDecoder);

As soon as Dagger 1.1 is out (likely this week), we'll have access to the SET_VALUES feature, which should allow us to eliminate the troublesome Module(overrides=true) features.

With this in, we should update examples and any how-to docs to show how to wire up feign so as to not require or suggest Module(overrides=true), except in very specific cases.

cc @benjchristensen

@codefromthecrypt
Copy link
Contributor Author

dropped support for dagger in #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant