Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2 package retains canonical import path from original code #63

Closed
bketelsen opened this issue Dec 19, 2023 · 1 comment · Fixed by #64
Closed

oauth2 package retains canonical import path from original code #63

bketelsen opened this issue Dec 19, 2023 · 1 comment · Fixed by #64
Labels
bug Something isn't working

Comments

@bketelsen
Copy link
Contributor

Description

oauth2 package retains canonical import path from original code, causing packages importing it to substitute the original golang.org/x/oauth2 package instead.

the credentials package in this repo imports oauth2/clientcredentials which has the canonical import path set to golang.org/x/oauth2.
@bketelsen bketelsen added the bug Something isn't working label Dec 19, 2023
This was referenced Dec 19, 2023
Merged
Closed
Closed
@rhamzeh rhamzeh closed this as completed Dec 19, 2023
@rhamzeh
Copy link
Member

rhamzeh commented Dec 19, 2023 •
edited

Thanks for your report and your PR @bketelsen ❤️ - this has now been released in v0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove canonical import path from oauth2 packages bketelsen/go-sdk
2 participants
@bketelsen @rhamzeh