Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested userset rewrite operands in the DSL in the Go bindings #132

Closed
rhamzeh opened this issue Jan 10, 2024 · 0 comments · Fixed by #136
Closed

Support nested userset rewrite operands in the DSL in the Go bindings #132

rhamzeh opened this issue Jan 10, 2024 · 0 comments · Fixed by #136
Assignees
Labels
bug Something isn't working

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Jan 10, 2024

Related to #16

Currently the Go bindings do not properly support mixed operators. Work has happened in #107 to add the bindings to JS

The following will result in incorrect JSON

Tests for these cases are already in place and the Go implementation fails on them

 define relation: (rel1 and rel2) but not rel3
 define relation: ((rel1 and rel2) but not rel3) # transformation back to DSL will not keep the extraneous surrounding brackets
 define relation: rel1 and (rel2 but not rel3)
 define relation: rel1 and ((rel2 but not rel3) or (rel4 and (rel5 but not rel6 from rel7)))
 define relation: [user, user:*, user#follower with condition] or ((rel1 and rel2) but not rel3)
 define relation: ([user] or ((rel1 and rel2)) but not rel3 
@rhamzeh rhamzeh added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jan 10, 2024
@jimmyjames jimmyjames self-assigned this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants