Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std::static_pointer_cast with std::dynamic_pointer_cast for polymorphic classes #135

Closed
dsuponitskiy opened this issue Jul 19, 2022 · 0 comments
Closed

Replace std::static_pointer_cast with std::dynamic_pointer_cast for polymorphic classes #135

dsuponitskiy opened this issue Jul 19, 2022 · 0 comments
Assignees
@dsuponitskiy
Labels
cleanup Code cleanup
Milestone
Preview Release 0...

Comments

@dsuponitskiy
Copy link
Collaborator

example: LeveledSHEBFVRNS::EvalMult() in src/pke/lib/scheme/bfvrns/bfvrns-leveledshe.cpp
the return type of GetCryptoParameters() is const std::shared_ptr<CryptoParametersBase>. It is cast to CryptoParametersBFVRNS using std::static_pointer_cast<>
@dsuponitskiy dsuponitskiy added the cleanup Code cleanup label Jul 19, 2022
@dsuponitskiy dsuponitskiy self-assigned this Jul 19, 2022
@dsuponitskiy dsuponitskiy changed the title Replace std::static_pointer_cast with std::dynamic_pointer_cast for polymorphic clases Replace std::static_pointer_cast with std::dynamic_pointer_cast for polymorphic classes Jul 20, 2022
@yspolyakov yspolyakov added this to the Preview Release 0.9.1 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuponitskiy dsuponitskiy

Labels
cleanup Code cleanup
Projects
None yet
Milestone
Preview Release 0.9.1
Development

No branches or pull requests
2 participants
@dsuponitskiy @yspolyakov