Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fast rotations in leveled BFV #569

Closed
andreea-alexandru opened this issue Oct 26, 2023 · 0 comments · Fixed by #625
Closed

Fix fast rotations in leveled BFV #569

andreea-alexandru opened this issue Oct 26, 2023 · 0 comments · Fixed by #625
Assignees
@dsuponitskiy @andreea-alexandru
Labels
bug Something isn't working
Milestone
Release 1.1.3

Comments

@andreea-alexandru
Copy link
Collaborator

andreea-alexandru commented Oct 26, 2023 •
edited by yspolyakov

  • Need evaluation format in EvalFastRotationPrecompute and to pass the appropriate parameters from digits instead of ciphertext in EvalFastRotation for both HYBRID and BV key switching.
  • Add unit tests to capture fast rotations in BFV both for when no moduli are dropped and some moduli are dropped.
@andreea-alexandru andreea-alexandru added the bug Something isn't working label Oct 26, 2023
@andreea-alexandru andreea-alexandru added this to the Release 1.1.2 milestone Oct 26, 2023
@andreea-alexandru andreea-alexandru self-assigned this Oct 26, 2023
@dsuponitskiy dsuponitskiy linked a pull request Dec 19, 2023 that will close this issue
569 fix fast rotations in leveled bfv #625
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuponitskiy dsuponitskiy

@andreea-alexandru andreea-alexandru

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.1.3
Development

Successfully merging a pull request may close this issue.

569 fix fast rotations in leveled bfv openfheorg/openfhe-development
3 participants
@dsuponitskiy @andreea-alexandru @yspolyakov