Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheme switching improvements #631

Closed
dsuponitskiy opened this issue Dec 22, 2023 · 0 comments · Fixed by #638
Closed

Scheme switching improvements #631

dsuponitskiy opened this issue Dec 22, 2023 · 0 comments · Fixed by #638
Assignees
@dsuponitskiy
Labels
cleanup Code cleanup optimization Improves performance
Milestone
Release 1.1.3

Comments

@dsuponitskiy
Copy link
Collaborator

  1. Add a parameter class for functions like EvalSchemeSwitchingSetup, EvalCKKStoFHEWSetup, etc.
  2. Check if parameters are passed to functions correctly (by value vs by pointer).
    ex: src/pke/lib/scheme/ckksrns/ckksrns-schemeswitching.cpp, line 1882 -> EvalCKKStoFHEWPrecompute(*cc, scaleCF);
@dsuponitskiy dsuponitskiy added cleanup Code cleanup optimization Improves performance labels Dec 22, 2023
@dsuponitskiy dsuponitskiy added this to the Release 1.1.3 milestone Dec 22, 2023
@dsuponitskiy dsuponitskiy self-assigned this Dec 22, 2023
@dsuponitskiy dsuponitskiy changed the title Scheme switching changes Scheme switching improvements Dec 22, 2023
@dsuponitskiy dsuponitskiy linked a pull request Jan 4, 2024 that will close this issue
Some code improvements for scheme switching #638
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuponitskiy dsuponitskiy

Labels
cleanup Code cleanup optimization Improves performance
Projects
None yet
Milestone
Release 1.1.3
1 participant
@dsuponitskiy