Haxe 3.2 and html5 target doesn't build

[ibilon]

lime test html5 -debug
Not_found

See HaxeFoundation/haxe#4067

Apparently it's a problem with the custom version of js/Boot.hx

[ibilon]

diff haxe.txt lime.txt 
24,35d23
< private class HaxeError extends js.Error {
< 
<       var val:Dynamic;
< 
<       public function new(val:Dynamic) {
<               super();
<               this.val = untyped __define_feature__("js.Boot.HaxeError", val);
<               untyped if (js.Error.captureStackTrace) js.Error.captureStackTrace(this, HaxeError);
<       }
< }
< 
< @:dox(hide)
82c70
<       static function getClass(o:Dynamic) : Dynamic {
---
>       static inline function getClass(o:Dynamic) : Dynamic {
96c84
<       @:ifFeature("has_enum")
---
>       @:ifFeature("may_print_enum")

[ibilon]

Changing the file to match haxe's resolve the issue.

[Simn]

What exactly was "patched" here anyway, and why?

[ibilon]

@Simn I tried a diff with this version (https://github.com/HaxeFoundation/haxe/blob/34849d14e9941714e228ed3a638af58a17c43d9d/std/js/Boot.hx), considering the dates it must be the one joshua used. There's no differences.

The commit message says "Include patched (dev branch) Haxe Boot class, to fix Safari issue", so that's the why.

[Simn]

But what exactly was fixed there? From what I can tell it only added inline to getClass.

[jgranick]

The old js.Boot failed on "Std.is" for things that were not Haxe types (things like Std.is (object, js.html.Image); failed)

Now that Haxe 3.2 is being released, we can either do away with the modified file, or we can likely use the 3.2 version as a patch for 3.1 users