Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] flatten module exports to allow job diagnostics #5

Closed
stuartc opened this issue Jul 12, 2022 · 0 comments
Closed

[compiler] flatten module exports to allow job diagnostics #5

stuartc opened this issue Jul 12, 2022 · 0 comments

Comments

@stuartc
Copy link
Member

stuartc commented Jul 12, 2022

All jobs are written with the assumption the functions will be injected at some point.
Jobs essentially have a const { a, b,c } = require(<adaptor>); prepended to them, it's technically a little different but the effect is the same.

In order for the typescript compiler to provide diagnostics (and without changing how Jobs are written) we should 'flatten' the export members of our dts files.

The compiler will then see export declare function foo().. as declare function foo()....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants