Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Be monorepo aware #55

Closed
josephjclark opened this issue Nov 2, 2022 · 0 comments · Fixed by #123
Closed

CLI: Be monorepo aware #55

josephjclark opened this issue Nov 2, 2022 · 0 comments · Fixed by #123

Comments

@josephjclark
Copy link
Collaborator

Now that we have a monorepo, we should make devtools aware of it.

If you're developing a language adaptor, you'll be writing it in the monorepo. You want to be able to use the new CLI to test that adaptor against jobs.

If you give the CLI a path to the monorepo, any adaptor imports should load straight from the monorepo.

This can be used a couple of ways:

  • pass in a monorepo=path/to/monorepo flag (or -m path/to/monotro)
  • Set an env var and pass a -M flag to the CLI (makes monorepo use easy but still won't load from the monorepo by default)

Some thoughts:

  • We should load from the build, not the source (this also ensures that .d.ts files are there)
  • Logging should make it very clear when adaptors have been loaded out of the monorepo (success level logging)
  • If using the monorepo all version stuff is ignored - no autoinstalls or anything, and any version directives in job code will be ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant