Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Icon loading on Canvas so the icons load in gracefully #1140

Closed
NickOpenFn opened this issue Sep 22, 2023 · 1 comment · Fixed by #1231
Closed

Improve Icon loading on Canvas so the icons load in gracefully #1140

NickOpenFn opened this issue Sep 22, 2023 · 1 comment · Fixed by #1231
Assignees
Labels
ux/ui improvement Improvements to the look, feel and usability of the system

Comments

@NickOpenFn
Copy link

Overview:

  1. The icons on the canvas look great, however they are loading in and rendering very abruptly.
  2. If there is any delay on the icons loading the text displays - which creates a strange experience of it loading "twice"

Possible Solutions:

  • Add in a animation & wording to display on the nodes (this is good regardless of issue 2 above)
  • Preload & cache the images to be ready to display when user logs in on the workflow overview page
  • If preloading is not possible, then perhaps we improve the perceived display of these with animations. We delay the text by showing and then image from showing by .250ms, and then hopefully the images will be ready and display before the text.
  • Another potential solution would be only to render the canvas once the images are ready.
@NickOpenFn NickOpenFn added the ux/ui improvement Improvements to the look, feel and usability of the system label Sep 22, 2023
@josephjclark
Copy link
Contributor

I noticed this yesterday.

This is a fairly easy fix - what's happening is the app is downloading the icon manifest every time it renders an icon. For some reason it seems to be doing it serially too. Basically move the fetchAdaptorIconsData function in Job.tsx elsewhere and call it on mount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/ui improvement Improvements to the look, feel and usability of the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants