Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start the worker in test mode #1435

Closed
jyeshe opened this issue Nov 22, 2023 · 1 comment · Fixed by #1494
Closed

Start the worker in test mode #1435

jyeshe opened this issue Nov 22, 2023 · 1 comment · Fixed by #1494
Assignees
@stuartc

Comments

@jyeshe
Copy link
Contributor

jyeshe commented Nov 22, 2023

The worker connects to Lightning using port 4000 on both dev and test environments.

In order to allow Lightning to run on dev and test mode simultaneously, the worker needs to start on test mode, connecting to port 4002.

Meanwhile, devs can also start Lightning for development on a port different than 4000.
@jyeshe jyeshe mentioned this issue Nov 23, 2023
Merged
4 tasks
@stuartc
Copy link
Member

stuartc commented Nov 23, 2023

Ah awesome I get it now 😅, if we can get test.exs to set the listen address then we should be good to have test envs live on port 4002..

stuartc added a commit that referenced this issue Nov 30, 2023
@stuartc
Get the endpoint configuration directly
d099bbd 
We now get the endpoint url for the worker directly from the running
Endpoint process.

In combination with adding `http: [port: 4002]` to the test.exs file
previously the worker endpoint url should be resolve reliably with
whatever endpoint configuration is available.

Re: #1433
Re: #1435
@stuartc stuartc mentioned this issue Nov 30, 2023
Merged
4 tasks
taylordowns2000 pushed a commit that referenced this issue Nov 30, 2023
@stuartc
Change AttemptView dataclip assigns to be asyncs (#1492)
7ed5cf7 
* Get the endpoint configuration directly

We now get the endpoint url for the worker directly from the running
Endpoint process.

In combination with adding `http: [port: 4002]` to the test.exs file
previously the worker endpoint url should be resolve reliably with
whatever endpoint configuration is available.

Re: #1433
Re: #1435

* Change assigns to asyncs to improve predictability of AttemptView tests

- Switched the `input_dataclip` and `output_dataclip` to be Asyncs so we
  can leverage `render_async` instead of waiting for a regular Task to
  call `send`.

Re: #1491
@jyeshe jyeshe assigned jyeshe and stuartc and unassigned jyeshe Nov 30, 2023
@jyeshe jyeshe mentioned this issue Nov 30, 2023
Merged
4 tasks
stuartc added a commit that referenced this issue Nov 30, 2023
@jyeshe @stuartc
Use dynamic Endpoint config only on prod (#1494)
517de58 
* Use dynamic Endpoint configuration only on prod
* Cleanup port config

Fixes #1435 
---------

Co-authored-by: Stuart Corbishley <corbish@gmail.com>
@NickOpenFn NickOpenFn reopened this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartc stuartc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use dynamic Endpoint config only on prod OpenFn/lightning
3 participants
@stuartc @jyeshe @NickOpenFn