Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Update Adaptor documentation to show functions exported from common #1733

Closed
mtuchi opened this issue Feb 9, 2024 · 2 comments · Fixed by #2232
Closed

Editor: Update Adaptor documentation to show functions exported from common #1733

mtuchi opened this issue Feb 9, 2024 · 2 comments · Fixed by #2232
Assignees

Comments

@mtuchi
Copy link
Contributor

mtuchi commented Feb 9, 2024

Description

Currently the inspector editor only shows the docs for adaptor specific function, but it does not show the functions that are exported from common in that adaptor. For example @openfn/language-http exports the following functions from @openfn/language-common.

alterState, arrayToString, combine, dataPath, dataValue, dateFns, each, field, fields, fn, chunk, humanProper, lastReferenceValue, merge, scrubEmojis, sourceValue, splitKeys, toArray,parseCsv,`. But these functions are not displayed on the inspector editor

Screenshot

Screenshot 2024-02-09 at 7 18 06 PM

Request in few words

Display the functions that are exported from language-common in all adaptors

@mtuchi mtuchi changed the title common exported docs on inspector common exported docs on editor inspector Feb 9, 2024
@josephjclark
Copy link
Contributor

I'm pretty sure we need to fix describe-package in kit before we can do anything about this. The flagship issue is OpenFn/kit#197

@christad92 christad92 changed the title common exported docs on editor inspector Editor: Update Adaptor documentation to show functions exported from common Feb 26, 2024
@josephjclark
Copy link
Contributor

josephjclark commented Mar 12, 2024

Hey that's strange, I don't think this exists on older http

Did we break something in http v6?

This is a screenshot from demo.openfn.org right now:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants