chore: cleanup language settings and language selector #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
reviewed
Feb 21, 2024
| @@ -9,7 +9,6 @@ export const useAppStore = defineStore('app', { | |||
| last_product_mode_used: 'barcode', | |||
| last_currency_used: 'EUR', // TODO: init with user locale ? | |||
| recent_locations: [], | |||
| language: localStorage.getItem('user-locale') || import.meta.env.VITE_DEFAULT_LOCALE, // 'en' | |||
There was a problem hiding this comment.
we should keep the user.language key here + a default value (null or VITE_DEFAUL_LOCALE) + indicate it will be a code (ex : 'en')
There was a problem hiding this comment.
It should indeed be here. I messed up when merging the changes from master in 2nd commit and deleted the line.
| @@ -113,12 +113,12 @@ export default { | |||
| methods: { | |||
| initUserSettingsForm() { | |||
| this.userSettingsForm.currency = this.appStore.user.last_currency_used | |||
| this.userSettingsForm.selectedLanguage = this.languageList.find(lang => lang.code === localeManager.guessDefaultLocale()) || this.languageList.find(lang => lang.code === 'en') | |||
| this.userSettingsForm.selectedLanguage = this.languageList.find(lang => lang.code === localeManager.guessDefaultLocale()).code | |||
There was a problem hiding this comment.
it feels strange that the guessDefaultLocale happens in the settings form (vs on app startup).
here it means the new user arrived on the app, the app will show up by default as 'en', right ? even if the user has a 'French' browser ? And after logging in, and going to its settings page, then the form field language will show 'French' 🤔
Or I'm missing something ? 😅
raphodn
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What