Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show tooltip on click (discount, date) #346

Merged
merged 1 commit into from
Feb 17, 2024
Merged

fix: show tooltip on click (discount, date) #346

merged 1 commit into from
Feb 17, 2024

Conversation

dq18
Copy link
Collaborator

@dq18 dq18 commented Feb 17, 2024

What

  • added possibility to show on click tooltips for "discount" and "date" for price cards since there is hovering is not feasible on touchscreen

@dq18 dq18 requested a review from raphodn February 17, 2024 00:06
raphodn
raphodn approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@raphodn raphodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool !

@raphodn raphodn changed the title feat: show discount and date tooltip on click fix: show discount and date tooltip on click Feb 17, 2024
@raphodn raphodn changed the title fix: show discount and date tooltip on click fix: show tooltip on click (discount, date) Feb 17, 2024
@raphodn raphodn merged commit ae424fe into master Feb 17, 2024
5 checks passed
@raphodn raphodn deleted the price_discount_date_click_tooltip branch February 17, 2024 12:45
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 17, 2024
Merged
@dq18 dq18 mentioned this pull request Feb 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphodn raphodn raphodn approved these changes

Assignees

@dq18 dq18

Labels
None yet
Projects
💸 Open Prices
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dq18 @raphodn